Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] spider: add initial changes for multipart/form-data handling #4795

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

karthikuj
Copy link
Contributor

Overview

Adds changes for spider to handle multipart/form-data enctype.

Related Issues

Specify any related issues or pull requests by linking to them.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Signed-off-by: karthikuj <karthikuj2001@gmail.com>
@karthikuj
Copy link
Contributor Author

Hey team,

this is still a work in progress. I had a couple doubts:

When I am running ./gradlew addOns:spider:cZAO I get an error since I need to modify the constructor in /zaproxy/zap/src/main/java/org/zaproxy/zap/model/DefaultValueGenerator.java, but when I do that and try to build the zaproxy repo I am getting another error which I am unable to resolve (attached a screenshot below), can you please guide me on how to fix this?

image

@thc202 thc202 changed the title [WIP] Adds initial changes for multipart/form-data handling [WIP] spider: add initial changes for multipart/form-data handling Aug 7, 2023
@thc202
Copy link
Member

thc202 commented Aug 7, 2023

You need to keep binary compatibility, you should add a new method rather than just changing the existing one. For the add-on, you will have to use reflection and fallback to call the older method.

Signed-off-by: karthikuj <karthikuj2001@gmail.com>
@kingthorin
Copy link
Member

@karthikuj do you plan to finish this?

@karthikuj
Copy link
Contributor Author

@karthikuj do you plan to finish this?

I do, just not getting the time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants