Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add Windows to CI workflow #4533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Add Windows to CI workflow #4533

wants to merge 1 commit into from

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Apr 6, 2023

Ensure all checks pass also in Windows (using Java 11).

@thc202 thc202 force-pushed the ci/os-win branch 3 times, most recently from d4f6b1b to 41654bf Compare April 6, 2023 09:13
kingthorin
kingthorin approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thc202
Copy link
Member Author

thc202 commented May 25, 2023

I still need to fix some test failures though.

@kingthorin
Copy link
Member

No problemo

@thc202 thc202 force-pushed the ci/os-win branch 2 times, most recently from c54b105 to 8656e50 Compare May 30, 2023 06:42
@thc202
Add Windows to CI workflow
3a8ef8e 
Ensure all checks pass also in Windows (using Java 11).

Signed-off-by: thc202 <thc202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiinon psiinon psiinon approved these changes

@kingthorin kingthorin kingthorin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@thc202 @kingthorin @psiinon