Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: Include the GraphiQL IDE with the add-on [WIP] #4269

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

graphql: Include the GraphiQL IDE with the add-on [WIP] #4269

wants to merge 2 commits into from

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Nov 27, 2022

No description provided.

@kingthorin
Copy link
Member

Now has a conflict too.

@ricekot ricekot changed the title graphql: Include the GraphiQL IDE with the add-on graphql: Include the GraphiQL IDE with the add-on [WIP] Jan 4, 2023
@ricekot
graphql: Include the GraphiQL IDE with the add-on
409ba23 
Signed-off-by: ricekot <github@ricekot.com>
@ricekot
Copy link
Member Author

ricekot commented Feb 16, 2023

This is ready for reviews now. However, it needs zaproxy/gradle-plugin-add-on#61 (and a release of version 0.9.0 of the plugin) and zaproxy/zaproxy#7729 to function correctly.

@ricekot
quickstart: Add "API Explore" button
9142bef 
Signed-off-by: ricekot <github@ricekot.com>
@thc202
Copy link
Member

thc202 commented Mar 15, 2023

The version 0.9.0 is now released.

thc202
thc202 reviewed Mar 16, 2023
View reviewed changes
...start/src/main/java/org/zaproxy/zap/extension/quickstart/apiexplore/ExtensionApiExplore.java
}
}
var buttonCount = buttonPanel.getComponentCount();
buttonPanel.add(getApiExploreButton(), buttonCount - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove on unload().

@thc202
Copy link
Member

thc202 commented Mar 16, 2023

Note I didn't review everything, spotted that while checking the core changes.

@kingthorin
Copy link
Member

Now has conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thc202 thc202 thc202 left review comments

@kingthorin kingthorin kingthorin approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@ricekot @kingthorin @thc202