Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requester: add support for persisting tabs in session database #4137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Warxim
Copy link

@Warxim Warxim commented Oct 16, 2022

Hello, I would like to add support for persisting Requester tabs in session database, so that we do not loose them every time we restart Zaproxy.

Solution summary:

  • Created table "REQUESTER_TAB" for persisting tabs.
  • Added support for serializing Message data and storing them as JSON.
  • Added support for deserializing JSON to Message.
  • Created wrapper to handle persistance logic for ManualHttpRequestEditorPanel. (Store message change when it is sent or added to the editor.)
  • Refactored tabbed pane (and related classes) to make them more simple and easily integrable with persistence logic.

@thc202 thc202 changed the title Add support for persisting Requester tabs in session database requester: add support for persisting tabs in session database Oct 16, 2022
@Warxim
Copy link
Author

Warxim commented Oct 16, 2022

Applied spotlessApply

@Warxim
Copy link
Author

Warxim commented Oct 19, 2022

Resolved conflicts (rebase)

@Warxim
Copy link
Author

Warxim commented Oct 24, 2022

@thc202 Hello, will you please look on this PR?

@thc202
Copy link
Member

thc202 commented Oct 24, 2022

I will once the main release is out.

@thc202
Copy link
Member

thc202 commented Oct 28, 2022

All classes that are not intended to be used by other add-ons (IMO all being added) should be placed under the internal package, to make that clear.

The pull request needs to be rebased.

@Warxim
Copy link
Author

Warxim commented Oct 28, 2022

Moved classes under the internal package.

@Warxim
Copy link
Author

Warxim commented Oct 28, 2022

Rebased onto current main.

@Warxim
Copy link
Author

Warxim commented Oct 28, 2022

Sorry for so many force pushes, noticed that my changelog line was moved to "7.0.0" section during the rebase. Moved it back to unreleased section.

@Warxim
Copy link
Author

Warxim commented Oct 28, 2022

Added @SuppressWarnings("serial") to UI classes, because of the failing build (18).

@Warxim
Copy link
Author

Warxim commented Dec 12, 2022

@thc202 Hello, can I help somehow, so that this PR can be approved and merged?

Signed-off-by: Michal Válka <michal.valka@warxim.com>
@Warxim
Copy link
Author

Warxim commented Dec 22, 2022

Rebased onto current main and resolved new conflicts. It is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants