ascanrules: Merge XSS detection logic of CrossSiteScriptingScanRule and PersistentXssScanRule #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogo Silva <diogomiresi@gmail.com>
Signed-off-by: Diogo Silva <diogomiresi@gmail.com>
DiogoMRSilva
changed the title
|
This will need some re-work after: #3838 is merged. Thanks for tackling this BTW!!! |
This comment was marked as resolved.
This comment was marked as resolved.
thc202
changed the title
…XssScanRule Signed-off-by: Diogo Silva <diogomiresi@gmail.com>
DiogoMRSilva
force-pushed
the
mergeXSSLogics
branch
from
3ad8742
to
288b0da
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both CrossSiteScriptingScanRule and PersistentXssScanRule need the same logic to detect the existence of an XSS only differing on the the HTTP request where the reflection is checked. At the moment stored XSS rule is not receiving all the upgrades and fixes the reflected XSS rule is receiving, this solves the problem and removes duplicated code.
Once Fix stored xss scanner is used the FPs on stored XSS start to appear.