Use of non root user, zap options and custom reports dir #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmatias
force-pushed
the
feature/use-of-non-root-user
branch
from
c362d6e
to
ac3c3bf
Compare
|
Thank you for the contribution, I'll test this over the weekend. |
|
@sshniro any news? |
|
This needs to be rebased to pick the latest changes, also, the commit history should be tidied up (better leave the dist generation in a last commit to make it easier to update). |
|
The changelog should be updated. |
juanmatias
force-pushed
the
feature/use-of-non-root-user
branch
from
ac3c3bf
to
abd5193
Compare
Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> Changed default Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> dist prepared Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> added zap options as a separate input so we can handle the double quotes around this param Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> added option to set reports directory Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> added new params to action.yml Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> doc improved Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> fixed styles Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> fixed styles Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <juanmatias@gmail.com> dist rebuild
juanmatias
force-pushed
the
feature/use-of-non-root-user
branch
from
abd5193
to
bd836a5
Compare
|
@thc202 sorry for the late reply, the branch was rebased, conflicts solved and all commits merged into one. Please, let me know what else I can do. |
|
Hi @juanmatias , I was not able to run this previously. Unfortunately, I can test this on Friday only. I will test and update the results. Apart from it, the code LGTM! |
|
For info the root user is no longer used as per #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use image ictu/zap2docker-weekly with this action. This because I need to login into the site with user and pwd.
To accomplish this I changed these:
If no parameters added, the defaults are to use root user, to have an empty string as zap parameters and to user current dir as base for reports.
In the readme it is explained and I added a simple example on how to use the after-mentioned image creating and publishing a report as artifact.