Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Drop nulldb adapter. #5065

Closed
wants to merge 7 commits into from
Closed

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Feb 23, 2024

Possible solution for zammad/zammad-helm#251. Opinions?

@mgruner mgruner changed the title Develop mg database url Maintenance: Improve handling of DATABASE_URL env var. Feb 23, 2024
@mgruner mgruner changed the title Maintenance: Improve handling of DATABASE_URL env var. Maintenance: Drop nulldb adapter. Mar 1, 2024
@mgruner mgruner requested a review from monotek March 1, 2024 07:55
@monotek
Copy link
Member

monotek commented Mar 1, 2024

Are we sure we don't need it anymore?
I try to remember for what exact reason i've added the nulldb adapter.
Seems to be some workaround to fix an issue with the docker builds: 04e2d8c

At least i can't find a "rake assets:precompile without db" in the code with a quick search 🤷

@mgruner
Copy link
Collaborator Author

mgruner commented Mar 1, 2024

@monotek yes, I believe that was the only reason. And as you can see by the changes in the build script, and the successful docker-ci job, building works without nulldb now. Ok?

@mgruner
Copy link
Collaborator Author

mgruner commented Mar 1, 2024

Merged in ed3a9d1, thanks.

@mgruner mgruner closed this Mar 1, 2024
@mgruner mgruner deleted the develop-mg-database-url branch March 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants