Core Workflows Fix for #5002 #5003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created method merge_changes_into_restrict_values to resolve cases where perform_result does not have some of the submitted data while being passed to CoreWorkflow.perform(). This resolves an issue encountered when core workflows remove groups, and then add them back to the group selection object later on.
Created method merge_changes_into_restrict_values to resolve cases where perform_result does not have some of the submitted data while being passed to CoreWorkflow.perform(). This resolves an issue encountered when core workflows remove groups, and then add them back to the group selection object later on.
Modifying return line to make validator workflow happy :)
|
Code works nicely with any of these commits Checks seem to not like the use of "do unless " syntax - changed to use if not syntax instead. |
|
Hi @bahusafoo , normally the concern is only the bridge between the core workflow engine and the rails model. I think the real reason for this issue is that there was no rerun for the group after the option was re-enabled so it was still restricted and did not recover the original state. But thank you very much for your encouragement :) Hopefully it will work for you too when it gets merged to stable soon. If not feel free to create a new issue with steps for reproduction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created method merge_changes_into_restrict_values to resolve cases where perform_result does not have some of the submitted data while being passed to CoreWorkflow.perform(). This resolves an issue encountered when core workflows remove groups, and then add them back to the group selection object later on.