Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Generate docker tags for Zammad major.minor and major versions #4920

Closed
wants to merge 2 commits into from

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Nov 8, 2023

This change will

  • add major.minor and major docker tags that can be used to get automatic updates with docker-compose and helm
  • remove the dysfunctional semver tag configuration - does not work because we don't use semver tags with v1.2.3
  • stop creating the duplicated zammad-* tags

@mgruner mgruner requested a review from monotek November 8, 2023 07:47
@mgruner
Copy link
Collaborator Author

mgruner commented Nov 8, 2023

@monotek can you please have a look? With Zammad 6.2, I would like to start pushing and updating tags like 6.2 and 6 (like it is done for https://hub.docker.com/r/selenium/standalone-chrome/tags, for example).
This will allow users to receive patchlevel updates automatically from docker-compose or helm without having to update the .env all the time.

The semver config we had there didn't seem to work at all, and I would also like to remove the zammad-* tags if you agree. What do you think?

@mgruner mgruner self-assigned this Nov 8, 2023
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but ci fails 🤷

@mgruner
Copy link
Collaborator Author

mgruner commented Nov 16, 2023

Thanks @monotek. CI was improved in the meantime and should work now. I will then remove the debug comments and merge this.

@mgruner mgruner deleted the develop-docker-tags branch November 17, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants