fix(frontend): select fields display value textmodule inconsistency #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arsa-dev Thanks for your contribution, hopefully, we can check this changes in the next weeks. Maybe you have the time to resolve the current conflicts? |
arsa-dev
force-pushed
the
fix-select-fields-textmodule-inconsistency
branch
from
3b7ef82
to
85ad2d7
Compare
Signed-off-by: Antonio Ramón Sánchez Morales <antonioramonsm@gmail.com>
arsa-dev
force-pushed
the
fix-select-fields-textmodule-inconsistency
branch
from
85ad2d7
to
5b78828
Compare
|
Hi @dominikklein, sorry for the delay. Did not had much time since your last comment but finally I had a bit of time today to rebase my changes and resolve conflicts with 9fd9e34#diff-ca9eabd9c8e72ad4811a516842cec350f4a62a6637b7fc5443ac860dd46e742f. I expect to be more available on next days so I'll probably will have some time to follow faster if there is any other indication or change to perform. Thanks and regards, Antonio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2745
This is an implementation that tries to follow notification factory renderer implementation merged with what I have seen for getting attributes on frontend.
Steps to reproduce
Tests made after changes