Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default overviews (seed) #4762

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

YetAnotherGerrit
Copy link
Collaborator

Revamp of the default overviews based on my consulting experience.

Revamp of the default overviews based on my consulting experience.
@YetAnotherGerrit
Copy link
Collaborator Author

image

@YetAnotherGerrit
Copy link
Collaborator Author

YetAnotherGerrit commented Aug 24, 2023

@martini informed me that changing the seed files might impact existing instances because translations will be removed from the translation tables. How can I prevent that?

Is there a file with deprecated strings, to keep them in translation?

@dominikklein
Copy link
Collaborator

@mgruner maybe some questions for you about the old strings? Also, checking the overview names from the title case perspective?

Comment on lines +6 to +7
name: __('Unassigned tickets'),
link: 'all_unassigned',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YetAnotherGerrit Until now, we used title case for the strings, as they usually appear on headings. Did you change that on purpose?

Regarding the old strings, you can probably just add a list of legacy strings at the end of the file with a leading comment line before them. The strings will do nothing there, but the extractor will find them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change that on purpose?

No, actually, it just felt more right to me. But I received multiple feedbacks already that they like "title case" more. I will update my PR back to title case. For me, the conceptional change is the important thing.

I will add the legacy string in the next commit as well. I will also update the translation catalog, so the CI-link runs successfully.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bring this forward in some way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is holding me back:
https://community.zammad.org/t/reduce-file-name-length-of-vcr-cassettes-files/12336

There are workarounds, but they are time consuming to discover.

@martini
Copy link
Collaborator

martini commented Oct 31, 2023

I think we need to setup a refinement for this to clarify why this change is needed and what this change is improving (to have a common understanding). I'm open for a change but (at least for me) it's not clear what the origin problem is.

Note: We should avoid to change the default overviews often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants