Maintenance: Stabilize field datetime visual regression tests.

zammad · May 1, 2024 · fcd4e39 · fcd4e39
1 parent 8ad0fd4
commit fcd4e39
Show file tree

Hide file tree

Showing 18 changed files with 9 additions and 7 deletions.
diff --git a/.cypress/cypress.config.mjs b/.cypress/cypress.config.mjs
@@ -3,7 +3,7 @@ import { rm } from 'node:fs/promises'
 import { resolve, dirname } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { initPlugin as initVisualRegressionPlugin } from '@frsource/cypress-plugin-visual-regression-diff/plugins'
-import pkg from '../package.json' assert { type: 'json' }
+import pkg from '../package.json' with { type: 'json' }
 
 const dir = dirname(fileURLToPath(import.meta.url))
 

diff --git a/app/frontend/apps/desktop/components/Form/fields/FieldDate/FieldDateTimeInput.vue b/app/frontend/apps/desktop/components/Form/fields/FieldDate/FieldDateTimeInput.vue
@@ -82,6 +82,7 @@ const dark = computed(() => theme.value === 'dark')
       :locale="i18n.locale()"
       :max-date="context.maxDate"
       :min-date="minDate"
+      :start-date="minDate || context.maxDate"
       :ignore-time-validation="!timePicker"
       :prevent-min-max-navigation="
         Boolean(minDate || context.maxDate || context.futureOnly)

diff --git a/app/frontend/apps/mobile/components/Form/fields/FieldDate/FieldDateTimeInput.vue b/app/frontend/apps/mobile/components/Form/fields/FieldDate/FieldDateTimeInput.vue
@@ -100,6 +100,7 @@ useEventListener('click', (e) => {
       :locale="i18n.locale()"
       :max-date="context.maxDate"
       :min-date="minDate"
+      :start-date="minDate || context.maxDate"
       :ignore-time-validation="!timePicker"
       :prevent-min-max-navigation="
         Boolean(minDate || context.maxDate || context.futureOnly)

diff --git a/...rm/fields/FieldDate/__image_snapshots__/date/renders basic date - filled #0.png b/...rm/fields/FieldDate/__image_snapshots__/date/renders basic date - filled #0.png
diff --git a/...m/fields/FieldDate/__image_snapshots__/date/renders basic date - focused #0.png b/...m/fields/FieldDate/__image_snapshots__/date/renders basic date - focused #0.png
diff --git a/...m/fields/FieldDate/__image_snapshots__/date/renders hidden date - filled #0.png b/...m/fields/FieldDate/__image_snapshots__/date/renders hidden date - filled #0.png
diff --git a/...s/Form/fields/FieldDate/__image_snapshots__/date/renders linked - filled #0.png b/...s/Form/fields/FieldDate/__image_snapshots__/date/renders linked - filled #0.png
diff --git a/.../Form/fields/FieldDate/__image_snapshots__/date/renders linked - focused #0.png b/.../Form/fields/FieldDate/__image_snapshots__/date/renders linked - focused #0.png
diff --git a/...fields/FieldDate/__image_snapshots__/date/renders required date - filled #0.png b/...fields/FieldDate/__image_snapshots__/date/renders required date - filled #0.png
diff --git a/...ields/FieldDate/__image_snapshots__/date/renders required date - focused #0.png b/...ields/FieldDate/__image_snapshots__/date/renders required date - focused #0.png
diff --git a/...s/FieldDate/__image_snapshots__/datetime/renders basic datetime - filled #0.png b/...s/FieldDate/__image_snapshots__/datetime/renders basic datetime - filled #0.png
diff --git a/.../FieldDate/__image_snapshots__/datetime/renders basic datetime - focused #0.png b/.../FieldDate/__image_snapshots__/datetime/renders basic datetime - focused #0.png
diff --git a/.../FieldDate/__image_snapshots__/datetime/renders hidden datetime - filled #0.png b/.../FieldDate/__image_snapshots__/datetime/renders hidden datetime - filled #0.png
diff --git a/...rm/fields/FieldDate/__image_snapshots__/datetime/renders linked - filled #0.png b/...rm/fields/FieldDate/__image_snapshots__/datetime/renders linked - filled #0.png
diff --git a/...m/fields/FieldDate/__image_snapshots__/datetime/renders linked - focused #0.png b/...m/fields/FieldDate/__image_snapshots__/datetime/renders linked - focused #0.png
diff --git a/...ieldDate/__image_snapshots__/datetime/renders required datetime - filled #0.png b/...ieldDate/__image_snapshots__/datetime/renders required datetime - filled #0.png
diff --git a/...eldDate/__image_snapshots__/datetime/renders required datetime - focused #0.png b/...eldDate/__image_snapshots__/datetime/renders required datetime - focused #0.png
diff --git a/app/frontend/cypress/apps/mobile/components/Form/fields/FieldDate/date-visuals.cy.ts b/app/frontend/cypress/apps/mobile/components/Form/fields/FieldDate/date-visuals.cy.ts
@@ -17,7 +17,7 @@ describe('testing visuals for "FieldDate"', () => {
       mountFormField(type, {
         id: 'datetime',
         label: 'Date',
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
       })
       checkFormMatchesSnapshot({ type })
       cy.findByLabelText('Date')
@@ -36,7 +36,7 @@ describe('testing visuals for "FieldDate"', () => {
       mountFormField(type, {
         id: 'datetime',
         label: 'Date',
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
         help: 'Help message!',
       })
       cy.findByLabelText('Date').then(() => {
@@ -49,7 +49,7 @@ describe('testing visuals for "FieldDate"', () => {
         id: 'datetime',
         label: 'Date',
         required: true,
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
       })
       checkFormMatchesSnapshot({ type })
       cy.findByLabelText('Date')
@@ -69,7 +69,7 @@ describe('testing visuals for "FieldDate"', () => {
         id: 'datetime',
         label: 'Date',
         required: true,
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
         validationVisibility: FormValidationVisibility.Live,
       })
       checkFormMatchesSnapshot({ type })
@@ -80,7 +80,7 @@ describe('testing visuals for "FieldDate"', () => {
         id: 'datetime',
         label: 'Date',
         link: '/',
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
       })
       checkFormMatchesSnapshot({ type })
       cy.findByLabelText('Date')
@@ -100,7 +100,7 @@ describe('testing visuals for "FieldDate"', () => {
         id: 'datetime',
         label: 'Date',
         disabled: true,
-        maxDate: '2021-02-01',
+        maxDate: '2021-01-31',
       })
       checkFormMatchesSnapshot({ type })
     })