feature: flightrecorder to enable Go trace #2985
Draft
+258
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proxy/proxy.go
Outdated
| return | ||
| } | ||
| // Write it to a file. | ||
| if err := os.WriteFile("trace.out", b.Bytes(), 0o755); err != nil { |
There was a problem hiding this comment.
How are we going to fetch this file if needed? Manually copying it from the pod? Or is there some automation?
There was a problem hiding this comment.
I cite "Ideas from discussion":
write to http endpoint PUT (think of cluster local service that collects the trace and make it available or S3)
szuecs
force-pushed
the
feature/flight-recorder
branch
from
74b6d67
to
e9d5125
Compare
config/config.go
Outdated
Comment on lines
387
to
382
| flag.IntVar(&cfg.FlightRecorderSize, "flight-recorder-size", 0, "max flight-recorder trace data size") | ||
| flag.DurationVar(&cfg.FlightRecorderPeriod, "flight-recorder-period", 0, "sets the approximate time duration that the flight recorder's circular buffer represents.") | ||
| flag.DurationVar(&cfg.FlightRecorderProxyTookTooLong, "flight-recorder-proxy-took-too-long", 0, "sets the threshold, if proxy took longer than that the flight recorder will write out a trace.") | ||
| flag.StringVar(&cfg.FlightRecorderTargetURL, "flight-recorder-target-url", "", "sets the flight recorder target URL that is used to write out the trace to.") |
There was a problem hiding this comment.
Maybe it would be better as a filter?
There was a problem hiding this comment.
Why do you think it's better that people have to pass their own URL into the filter?
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
b23465b
to
c42035a
Compare
|
I get only errors for Go 1.22 support: Without forcing Go1.22 I get: I don't really know why: https://pkg.go.dev/golang.org/x/exp/trace#FlightRecorder should not depend on Go version, because x/ is a separate package. Maybe it's really an issue created by go-fuzz. Maybe fixed by google/oss-fuzz#11677 |
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs
force-pushed
the
feature/flight-recorder
branch
from
f7e2831
to
b9d62b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: flightrecorder to enable Go trace
https://go.dev/blog/execution-traces-2024
https://pkg.go.dev/golang.org/x/exp/trace#FlightRecorder
wdyt?
Ideas from discussion