secrets: handle empty secrets #2620
Draft
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs error on add and treat empty file as removed on update. In particular it errors instead of using empty value when secret path comes from process substitution ``` $ bin/routesrv -kubernetes-token-file=<(echo foobar) ERRO[0000] Failed to read file /dev/fd/63: empty file FATA[0000] failed to get secret /dev/fd/63 ``` which is a symlink to a named pipe ``` $ ls -l <(echo foobar) lr-x------ 1 jdoe jdoe 64 Sep 25 13:36 /dev/fd/63 -> 'pipe:[7925874]' ``` Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
👍 |
|
pipeline flaked due to #2621 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs error on add and treat empty file as removed on update.
In particular it errors instead of using empty value when secret path comes from process substitution
which is a symlink to a named pipe