test: swarm code #2288
Open
test: swarm code #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
config/config.go
Outdated
Comment on lines
532
to
554
| flag.StringVar(&cfg.SwarmKubernetesNamespace, "swarm-namespace", "", "Kubernetes namespace to find swarm peer instances") | ||
| flag.StringVar(&cfg.SwarmKubernetesLabelSelectorKey, "swarm-label-selector-key", "", "Kubernetes labelselector key to find swarm peer instances") | ||
| flag.StringVar(&cfg.SwarmKubernetesLabelSelectorValue, "swarm-label-selector-value", "", "Kubernetes labelselector value to find swarm peer instances") |
There was a problem hiding this comment.
This looks like a breaking change, no?
There was a problem hiding this comment.
That's just a WIP PR, see label and I think no right now it's not breaking here, because the defaults are set in the library code.
refactor: remove custom kubernetes client and reuse dataclient kubernetes Signed-off-by: Sandor Szuecs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szuecs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szuecs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szuecs <sandor.szuecs@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: swarm code
refactor: remove custom kubernetes client and reuse dataclient kubernetes