add sync_priority as sorting criteria to sync ReplicaList #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberDem0n
reviewed
May 13, 2024
There was a problem hiding this comment.
There is no value in ordering by sync_priority.
The thing is, that Patroni enforces the number of nodes required to be synchronous to always match with the number of nodes listed in the synchronous_standby_names. Effectively these nodes are treated equally, no matter what sync_priority value they have (which is IIRC assigned from the position in the synchronous_standby_names).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sync_standby list more stable when changing synchronous_node_count, I add sync_priority as sorting criteria to sync ReplicaList following sync_state and lsn. This PR is to solve issue #3061. Please help review if such change is OK and has no potential issues. Thanks.