Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct etcd to delete old revisions #3024

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

hedleyroos
Copy link
Contributor

Etcd keeps old revisions unless instructed to delete them. If we don't delete old revisions then etcd memory usage will keep growing forever due to keepalive updates. Since Patroni does not really need to roll back to older revisions we can safely delete them.

Etcd keeps old revisions unless instructed to delete them. If we don't delete old revisions then etcd memory usage will keep growing forever due to keepalive updates. Since Patroni does not really need to roll back to older revisions we can safely delete them.
Instruct etcd to delete old revisions
docker/entrypoint.sh Outdated Show resolved Hide resolved
@CyberDem0n
Copy link
Collaborator

👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9059959544

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 99.862%

Files with Coverage Reduction New Missed Lines %
patroni/ha.py 2 99.84%
patroni/collections.py 3 94.64%
patroni/psycopg.py 3 78.57%
Totals Coverage Status
Change from base Build 7898066020: 0.001%
Covered Lines: 13760
Relevant Lines: 13779

💛 - Coveralls

@hughcapet hughcapet added this to the Sprint 2024.08 milestone May 13, 2024
@hughcapet
Copy link
Member

👍

@hughcapet hughcapet merged commit ff31f45 into zalando:master May 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants