Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Note that restart is required for Consul reconfiguration #1478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NikolayS
Copy link
Contributor

@NikolayS NikolayS commented Apr 2, 2020

TODO

  • check (or add) words about how to restart properly
  • what is the exact list of params changing which requires a restart?

docs/SETTINGS.rst Outdated Show resolved Hide resolved
docs/SETTINGS.rst Outdated Show resolved Hide resolved
Not all Consul params need a restart to apply a change. Adjust the phrase and mark those that do not require a restart.
@NikolayS
Copy link
Contributor Author

NikolayS commented Apr 15, 2020

@CyberDem0n adjusted the text and marked token and consistency as not requiring a restart to apply a change.

What about etcd, zookeeper, and k8s parameters? Is it the same, a restart is needed when we need to change them?

@CyberDem0n
Copy link
Collaborator

For consul there is also dc that could be changed without a restart (not sure if somebody even using it).
The kubernetes configuration supposed to be static due to its nature and therefore restart is always required.
For etcd there is nothing yet what could be changed without a restart, but in the future username and password will be supported.
For zookeeper there is nothing to change without a restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants