Add a method to authenticate without a config file #53
Conversation
|
@calston can you fix the DCO (git commit -s -amend), we need to be compliant |
| @@ -69,6 +72,20 @@ func Setup(redirectURL, credFile string, scopes []string, secret []byte) { | |||
| } | |||
| } | |||
|
|
|||
| // Setup the authorization path without a config file | |||
| func SetupFromString(redirectURL, cLoginURL string, clientID string, clientSecret string, scopes []string, secret []byte) { | |||
There was a problem hiding this comment.
Function should be Setup or maybe create an Options{} struct to pass it
There was a problem hiding this comment.
Are you suggesting @calston modify the existing Setup? Adding functionality with a new SetupFromString would only be a minor version update, opposed to a major version update. I'm in favor of their current implementation.
There was a problem hiding this comment.
Maybe SetupWithOptions(o Options)
| @@ -7,7 +7,7 @@ import ( | |||
| "crypto/rand" | |||
| "encoding/base64" | |||
| "encoding/json" | |||
| "fmt" | |||
| //"fmt" | |||
| @@ -102,7 +119,8 @@ func Auth() gin.HandlerFunc { | |||
| session := sessions.Default(ctx) | |||
| retrievedState := session.Get("state") | |||
| if retrievedState != ctx.Query("state") { | |||
| ctx.AbortWithError(http.StatusUnauthorized, fmt.Errorf("Invalid session state: %s", retrievedState)) | |||
| ctx.Redirect(302, loginURL) | |||
There was a problem hiding this comment.
redirect makes sense, please just drop commented lines :)
| @@ -69,6 +72,20 @@ func Setup(redirectURL, credFile string, scopes []string, secret []byte) { | |||
| } | |||
| } | |||
|
|
|||
| // Setup the authorization path without a config file | |||
| func SetupFromString(redirectURL, cLoginURL string, clientID string, clientSecret string, scopes []string, secret []byte) { | |||
There was a problem hiding this comment.
Are you suggesting @calston modify the existing Setup? Adding functionality with a new SetupFromString would only be a minor version update, opposed to a major version update. I'm in favor of their current implementation.
| func randToken() string { | ||
| b := make([]byte, 32) | ||
| rand.Read(b) | ||
| return base64.StdEncoding.EncodeToString(b) | ||
| } | ||
|
|
||
| // Setup the authorization path | ||
| func Setup(redirectURL, credFile string, scopes []string, secret []byte) { | ||
| func Setup(redirectURL, cLoginURL string, credFile string, scopes []string, secret []byte) { |
There was a problem hiding this comment.
I wouldn't modify this function signature. Doing so will break existing functionality and require a major version increment. Could we maybe use a mutator/setter to set the loginURL, something like SetLoginURL(loginURL string)?
There was a problem hiding this comment.
Or something like WithLoginURL(s string)
I'd rather do this myself in a larger generic config file, probably other people to?