Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Configure session timeous globally #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jumpojoy
Copy link

Previously timeouts were configured only for watching requests, this patch
make them configured directly in session constructor.

@jumpojoy jumpojoy requested a review from nolar as a code owner June 24, 2020 10:29
@zincr
Copy link

zincr bot commented Jun 24, 2020

🤖 zincr found 2 problems , 0 warnings

❌ Approvals
❌ Specification
✅ Large Commits
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 2 additional users, who have not contributed to this pull request approve the changes.

  • ❌ 2 additional approvals needed
     

Specification

All pull requests must follow certain rules for content length and form

Please ensure the follow issues are resolved:

  • ✅ Pull Request Title must be atleast 8 characters
  • ✅ Pull Request body must be atleast 8 characters
  • ❌ Pull Request body must contain issue number
     

@jumpojoy jumpojoy force-pushed the sess_timeout branch 2 times, most recently from 4232ec3 to f7ee618 Compare June 25, 2020 18:43
Previously timeouts were configured only for watching requests, this patch
make them configured directly in session constructor.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant