Optionally remove the Status handler_id prefix #320
Conversation
As proposed in issue zalando-incubator#319, this introduces an optional status_prefix boolean that can be added to any resource handler definition. If set to True (or omitted), status returned by the handler is still placed beneath the handler_id in the resulting object's status subresource. If set to False, the status returned by the handler is use at the top-level of the status subresource. Default handler with status_prefix=True: @kopf.on.create('zalando.org', 'v1', 'kopfexamples') def create(...): return {'my': 'result} Result: ... Status: Create: My: Result Handler with status_prefix=False: @kopf.on.create('zalando.org', 'v1', 'kopfexamples', status_prefix=False) def create(...): return {'my': 'result} Result: ... Status: My: Result
🤖 zincr found 1 problem , 0 warningsDetails on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 2 additional users, who have not contributed to this pull request approve the changes.
|
|
This would be a really nice feature to have |
|
Hey @lack, If you don't have time at the moment would it be ok if I pick this up based on the changes you already made? |
|
@philipp-sontag-by : I'll try to redo this in the other repo, but I may not have time in the near future (starting a new job this week). I'd also be happy for you to carry this forward if you have time. Let me know here if you've got it in another PR so we don't duplicate effort. |
What do these changes do?
As proposed in issue #319, this introduces an optional
status_prefixboolean that can be added to any resource handler definition. If set toTrue(or omitted), status returned by the handler is still placed beneath the handler_id in the resulting object's status subresource. If set toFalse, the status returned by the handler is use at the top-level of the status subresource.Description
Fully implements the proposal in issue #319.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt