Add loading indicator #2398
Open
Add loading indicator #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zadam, this PR is not done yet. I'm currently figuring out how to replace the page. Could you help me out please? |
|
Why do you mean by "replace a page"? |
|
Replace the note type (See |
|
These widgets are controlled by note type, but "loading" is no note type. So I guess I would probably try to solve that in another way. Maybe some completely separate widget somewhere here But in general I'm not sure how to do this right. It's important that when the networks is fast there shouldn't be any flashing caused by this loading appearing and quickly disappearing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful if there is some kind of loading indicator when clicking on a note