src/libs/zbxsysinfo/netbsd/net.c: convert to using the now-preferred sysctl() method. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sysctl() method of getting at the network statistics is the preferred method on NetBSD nowadays. The code to do so is lifted from NetBSD's netstat/if.c and adapted as required. This fixes a build problem on netbsd-10 where the internal data structure has changed to use per-CPU counters, and the code has been tested on NetBSD 8.2, so this method also works in now quite old NetBSD hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sysctl() method of getting at the network statistics is the preferred method on NetBSD nowadays. The code to do so is lifted from NetBSD's usr.bin/netstat/if.c and adapted as required.
This fixes a build problem on netbsd-10 where the internal data structure has changed to use per-CPU counters, and the code has been tested on NetBSD 8.2, so this method also works in now quite old NetBSD hosts.