Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building snaps #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

popey
Copy link

@popey popey commented Feb 2, 2018

This tiny pull request adds support to build cumulonimbus as a snap.

cumulonimbus is already available in the snap store via the yaml in the snapcrafter which consumes the deb and pushes that into a snap. This PR takes a pleasant approach of using the built-in snap output of electron-builder.

If the PR is accepted, we can transfer ownership of the cumulonimbus snap to you, the upstream developer. Once done you could automatically upload the built snaps to the store using snapcraft push. With multiple channels in the store, you could have adventurous users get automatic updates to your latest pre-release builds of cumulonimbus, and provide feedback based on the latest build.

If accepted, I'm happy to walk you through the next steps.

@z-------------
Copy link
Owner

I'd be very happy to support building Cumulonimbus as a snap, but the problem I have been facing is that I can't seem to get Travis CI to do it without erroring — there are always problems with installing certain things required for building snaps.

Once I figure out how to get it working with Travis I'd be glad to merge this PR and take ownership of the snap.

Thanks!

@z------------- z------------- self-assigned this Feb 3, 2018
@popey
Copy link
Author

popey commented Feb 3, 2018

Yeah, it's a known problem with snaps being built on trusty travis images. Can you try building on a xenial image in travis?

@z------------- z------------- added this to To do in Meta Mar 15, 2018
@3v1n0
Copy link

3v1n0 commented Apr 12, 2018

In order to build a snap in travis you should use a xenial docker image.... You can see examples for that here https://github.com/nextcloud/client_theming/blob/master/.travis.yml and https://github.com/nextcloud/client_theming/blob/master/linux/travis-build.sh

However using http://build.snapcraft.io/ would be at this point way easier

@z-------------
Copy link
Owner

@3v1n0 I will look into using build.snapcraft.io. Thanks for the suggestion.

@Lvaskz
Copy link

Lvaskz commented May 22, 2018

hi, any advance?

@z-------------
Copy link
Owner

z------------- commented May 22, 2018

Hi @Lvaskz, this issue is pretty low on my priority list so I haven't made any progress yet. I will definitely get around to it some day, though.

@Lvaskz
Copy link

Lvaskz commented May 22, 2018

oh right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Meta
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

4 participants