Fix rendering Mermaid diagrams to PDFs and images #365
+1,005
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haensen
changed the title
haensen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #312, #318, #337 and #342.
Also, enables using Mermaid's newest features like xychart-beta with this tool.
The root cause of the problem was that sometime after and around version 10.5 Mermaid started using features that were unsupported by the Chromium version that this tool used. At least structuredClone-function was one such feature. So this fix pumps the Puppeteer from version 2.21 to 22.7.1, which pumps Chromium from version 80 to 124.
Also, the line that removes Chromium from the package is removed, because after Puppeteer v19 Chromium is stored to ~/.cache, which doesn't affect the package size.