Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/remove kubernetes depend #9204

Merged
merged 1 commit into from Dec 4, 2020

Conversation

zexi
Copy link
Member

@zexi zexi commented Dec 4, 2020

这个 PR 实现什么功能/修复什么问题:

目前别的仓库要将 onecloud 作为 go mod 导入,都必须在 go.mod 里面强行写上 replace k8s.io 相关的依赖,更新 mod 的时候非常痛苦。

把 k8s.io/kubernetes 的依赖去掉,根据 kubernetes/kubernetes#90358 ,发现 k8s.io/kubenretes 不支持作为 go mod 导入。

去掉这个依赖后,可以方便其它仓库将 yunion.io/x/onecloud 作为 go mod 导入。

是否需要 backport 到之前的 release 分支:

  • 3.6

/cc @yousong @wanyaoqi

/area util

@yousong
Copy link
Contributor

yousong commented Dec 4, 2020

/lgtm

@yunion-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@zexi
Copy link
Member Author

zexi commented Dec 4, 2020

Solve issue: #9201

@yunion-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yousong
You can assign the PR to them by writing /assign @yousong in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zexi zexi force-pushed the hotfix/remove-kubernetes-depend branch from 10d0f94 to 3efa2c6 Compare December 4, 2020 08:28
@codecov-io
Copy link

Codecov Report

Merging #9204 (c025944) into master (ddf7e8b) will increase coverage by 0.00%.
The diff coverage is 53.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9204   +/-   ##
=======================================
  Coverage    5.82%    5.83%           
=======================================
  Files         838      839    +1     
  Lines      130585   130598   +13     
=======================================
+ Hits         7611     7616    +5     
- Misses     122292   122296    +4     
- Partials      682      686    +4     
Flag Coverage Δ
aFlag 5.83% <53.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/k8s/kubeadm/kubeadm.go 53.84% <53.84%> (ø)
pkg/appsrv/response.go 64.40% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf7e8b...c025944. Read the comment docs.

@zexi zexi merged commit eb3c87b into yunionio:master Dec 4, 2020
zexi added a commit that referenced this pull request Dec 4, 2020
…tream-release-3.6

Automated cherry pick of #9204: Hotfix/remove kubernetes depend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants