New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/remove kubernetes depend #9204
Conversation
544d950
to
66397e9
Compare
/lgtm |
66397e9
to
10d0f94
Compare
New changes are detected. LGTM label has been removed. |
Solve issue: #9201 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10d0f94
to
3efa2c6
Compare
3efa2c6
to
c025944
Compare
Codecov Report
@@ Coverage Diff @@
## master #9204 +/- ##
=======================================
Coverage 5.82% 5.83%
=======================================
Files 838 839 +1
Lines 130585 130598 +13
=======================================
+ Hits 7611 7616 +5
- Misses 122292 122296 +4
- Partials 682 686 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…tream-release-3.6 Automated cherry pick of #9204: Hotfix/remove kubernetes depend
这个 PR 实现什么功能/修复什么问题:
目前别的仓库要将 onecloud 作为 go mod 导入,都必须在 go.mod 里面强行写上 replace k8s.io 相关的依赖,更新 mod 的时候非常痛苦。
把 k8s.io/kubernetes 的依赖去掉,根据 kubernetes/kubernetes#90358 ,发现 k8s.io/kubenretes 不支持作为 go mod 导入。
去掉这个依赖后,可以方便其它仓库将 yunion.io/x/onecloud 作为 go mod 导入。
是否需要 backport 到之前的 release 分支:
/cc @yousong @wanyaoqi
/area util