Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for slackdiff. #3144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for slackdiff. #3144

wants to merge 1 commit into from

Conversation

Punicaa
Copy link
Contributor

@Punicaa Punicaa commented Apr 29, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

  • Updated slackdiff.rb to use slack_ruby_client instead of slack-api.
  • Updated default timeout from 20 to 60.

Fixes users experiencing the following error:

ERROR -- : Hook slack (#SlackDiff:0x00005572c9621e20) failed (#<NameError: uninitialized constant Slack::Client>) for event :post_store #2697

- Updated slackdiff.rb to use slack_ruby_client insteaf of slack-api.
@robertcheramy
Copy link
Collaborator

I miss the update of the default timeout in the diff. Can you check that?
Can you also merge master into your branch (or rebase it, as you which), and modify Changelog so that the changes are under the unreleased Version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants