Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extractor/common] Fix crash in _report_ignoring_subs #32762

Merged
merged 6 commits into from Apr 5, 2024
Merged

[extractor/common] Fix crash in _report_ignoring_subs #32762

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aaaf18a
[extractor/common] Fix crash in _report_ignoring_subs
salty-horse Apr 3, 2024
8d55e43
Bring utils.py into the PR
dirkf Apr 5, 2024
e83b4e4
Make `bug_reports_message()` fully updatable
dirkf Apr 5, 2024
18d4b34
Apply suggestions from code review
dirkf Apr 5, 2024
9ae12dc
Revert and fix `utils.bug_reports_message()` (2)
dirkf Apr 5, 2024
6c9912e
Remove initial space that is added in l.2391 if needed.Update youtube…
dirkf Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 15 additions & 6 deletions youtube_dl/utils.py
View file
Open in desktop
Expand Up @@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):
return YoutubeDLHTTPSHandler(params, context=context, **kwargs)


def bug_reports_message():
def bug_reports_message(before=';'):
if ytdl_is_updateable():
update_cmd = 'type youtube-dl -U to update'
else:
update_cmd = 'see https://yt-dl.org/update on how to update'
msg = '; please report this issue on https://yt-dl.org/bug .'
msg += ' Make sure you are using the latest version; %s.' % update_cmd
msg += ' Be sure to call youtube-dl with the --verbose flag and include its complete output.'
return msg
update_cmd = 'see https://github.com/ytdl-org/youtube-dl/#user-content-installation on how to update'

msg = (
' please report this issue on https://github.com/ytdl-org/youtube-dl/issues ,'
dirkf marked this conversation as resolved.
Show resolved Hide resolved
' using the appropriate issue template.'
' Make sure you are using the latest version; %s.'
' Be sure to call youtube-dl with the --verbose option and include the complete output.'
) % update_cmd

before = (before or '').rstrip()
if not before or before.endswith(('.', '!', '?')):
msg = msg[0].title() + msg[1:]

return (before + ' ' if before else '') + msg


class YoutubeDLError(Exception):
Expand Down