[XFileShare] Update for 2024 with new InfoExtractor features #32725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2024
dirkf
commented
Feb 22, 2024
dirkf
commented
Feb 22, 2024
dirkf
commented
Feb 22, 2024
dirkf
commented
Feb 23, 2024
dirkf
commented
Feb 23, 2024
dirkf
force-pushed
the
df-xfileshare-update
branch
from
e281c05
to
75df4b9
Compare
* uses the error diagnostic to truncate the JSON string * may be confused by non-C-Pythons
* use traverse_obj() and _search_json()
* support playlist `.load({**video1},{**video2}, ...)`
* support transform_source=... for _extract_jwplayer_data()
dirkf
force-pushed
the
df-xfileshare-update
branch
from
75df4b9
to
c19c37d
Compare
* simplify aa_decode() * review and update supported sites and tests * in above, include FileMoon.sx, and remove separate module * incorporate changes from yt-dlp * allow for decoding multiple scripts (eg, FileMoon) * use new JWPlayer extraction
dirkf
force-pushed
the
df-xfileshare-update
branch
from
c19c37d
to
132fb77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: improvement/own code
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR updates the XFileShare extractor module in three steps:
adds a
_search_json()method toInfoExtractormatching the yt-dlp method; it uses the error diagnostic to truncate extra text from the JSON string, which might be confused by a Pythonjsonlibrary implementation that uses a different diagnostic template;updates the common JWPlayer extraction to use
traverse_obj()and_search_json(), to support extracting playlists in a.load({**video1},{**video2}, ...)fragment, and to support atransform_sourceparameter in_extract_jwplayer_data();updates the
XFileShareIEextractor to make use of these features.As a result, filemoon.sx can be supported as one of the known sites and its separate extractor is removed: resolves #32716.
Supersedes, closes #32452.