Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to add nest extractor #32616

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EthanMuir
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@dirkf
Copy link
Contributor

dirkf commented Dec 2, 2023

Please

  1. revert commit e8eb999 in this branch (maybe review PR [bandlabextractor] added new bandlab extractor for track, album, and playlist… #31206 and offer any good bits from the commit there?)
  2. complete the PR template.

@dirkf
Copy link
Contributor

dirkf commented Dec 2, 2023

And
3. consider incorporating PR #31274, stalled because the PR author didn't respond to review comments, or closing this in favour of it in case I might have time to finish it myself.

@dirkf dirkf marked this pull request as draft December 2, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants