Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[caffeine.tv] Add new extractor #32514

Merged
merged 4 commits into from Feb 22, 2024
Merged

[caffeine.tv] Add new extractor #32514

merged 4 commits into from Feb 22, 2024

Conversation

aaron-tan
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add info extractor to support site caffeine.tv

Closes #31016

Add CaffeineIE info extractor to support site caffeine.tv
Refactor code to better reflect coding conventions
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I've made some suggestions (syntax not fully guaranteed): please have a look.

youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
youtube_dl/extractor/caffeine.py Outdated Show resolved Hide resolved
@dirkf dirkf merged commit 40bd5c1 into ytdl-org:master Feb 22, 2024
14 checks passed
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Feb 22, 2024
* https://github.com/ytdl-org/youtube-dl:
  [caffeine.tv] Add new extractor (ytdl-org#32514)
  [GBNews]Add new extractor for GB News TV channel (ytdl-org#29432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caffeine support
2 participants