Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Under-the-hood fixes, improvements and tests (pt 3) #32490

Merged
merged 4 commits into from Aug 1, 2023

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Jul 31, 2023

Boilerplate: own/yt-dlp code, bug fix/improvement ## Please follow the guide below
  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • Except for code from yt-dlp, for which this or the below have been asserted, I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

After merging #32481, one further change was needed. Meanwhile new flake8 Linter rules appeared. This PR addresses both.

To pass new Linter rules, direct comparison to types is reworked and at the same time isinstance() tests (especially for str/unicode/bytes) are revised, avoiding actual Python version tests as far as possible

@dirkf dirkf merged commit 2efc8de into ytdl-org:master Aug 1, 2023
14 checks passed
@dirkf dirkf deleted the master-32490 branch August 1, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant