Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infomaniak] Add new extractor to resolve #31329 #31981

Closed
wants to merge 5 commits into from
Closed

[infomaniak] Add new extractor to resolve #31329 #31981

wants to merge 5 commits into from

Conversation

ishabahmed
Copy link

@ishabahmed ishabahmed commented Apr 1, 2023

I have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense.

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of my pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of my pull request and other information

Added an extractor to support player.vod2.infomaniak.com as requested in #31329

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I've made some small suggestions.

youtube_dl/extractor/infomaniak.py Outdated Show resolved Hide resolved
youtube_dl/extractor/infomaniak.py Outdated Show resolved Hide resolved
youtube_dl/extractor/infomaniak.py Outdated Show resolved Hide resolved
youtube_dl/extractor/infomaniak.py Outdated Show resolved Hide resolved
@ishabahmed
Copy link
Author

Thanks for the help with further understanding the codebase and project convention.

@ishabahmed ishabahmed requested a review from dirkf April 2, 2023 18:11
@ishabahmed ishabahmed closed this by deleting the head repository Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants