Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chelseafc] Add new extractor #31918

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

01001110
Copy link

@01001110 01001110 commented Mar 23, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Resolves #31412.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, even if I might have preferred qpr.co.uk!

I've made some suggestions. Try them out and I'll enable the CI test.

youtube_dl/extractor/chelseafc.py Outdated Show resolved Hide resolved
youtube_dl/extractor/chelseafc.py Outdated Show resolved Hide resolved
youtube_dl/extractor/chelseafc.py Outdated Show resolved Hide resolved
youtube_dl/extractor/chelseafc.py Outdated Show resolved Hide resolved
youtube_dl/extractor/chelseafc.py Outdated Show resolved Hide resolved
@Tom1380
Copy link

Tom1380 commented May 25, 2023

Anything new?

@aaron-tan
Copy link
Contributor

I've tried to test this extractor by downloading the example URL video: https://www.chelseafc.com/en/video/first-half--manchester-united-v-chelsea--a--5smw5iate62dthdwoxsafx-csrrsy0%E2%80%A6 but unfortunately it returned HTTP Error 404: Forbidden. Is the extractor working?

@01001110
Copy link
Author

01001110 commented Oct 2, 2023

I've tried to test this extractor by downloading the example URL video: https://www.chelseafc.com/en/video/first-half--manchester-united-v-chelsea--a--5smw5iate62dthdwoxsafx-csrrsy0%E2%80%A6 but unfortunately it returned HTTP Error 404: Forbidden. Is the extractor working?

@aaron-tan I just tested it with your URL, and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chelsea FC
4 participants