[GBNews]Add new extractor for GB News TV channel #29432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small issue in the URL regex, videos on gbnews are not exclusive to |
|
Apparently any text (let's say alphanumeric and _) can go in place of |
Allow alphanumeric and _ in place of `shows`, which redirect to site's preferred URL
This was referenced Feb 11, 2024
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Feb 22, 2024
* https://github.com/ytdl-org/youtube-dl: [caffeine.tv] Add new extractor (ytdl-org#32514) [GBNews]Add new extractor for GB News TV channel (ytdl-org#29432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Issue #29341 identified the need for an extractor for the new GB News channel from the UK, and demonstrated extraction using a shell script.
This PR adds an extractor for the two types of GB News URLs (clips, live) shown in the issue, using the procedure from the issue.
The live stream appears to operate OK with a shell command line piping yt-dl output to
mpv, but hasn't been extensively exercised.Closes #29341.