Skip to content

Commit

Permalink
[YouTube] Support @owner format in uploader_id etc
Browse files Browse the repository at this point in the history
* implement #31530 (comment)
* update affected tests
* misc clean-ups
  • Loading branch information
dirkf committed Feb 24, 2023
1 parent e67e52a commit f7ce98a
Showing 1 changed file with 194 additions and 125 deletions.

9 comments on commit f7ce98a

@sheenilim08
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So when can we see this publish to the https://yt-dl.org/downloads/latest/youtube-dl?

@tansy

This comment was marked as resolved.

@dirkf
Copy link
Contributor Author

@dirkf dirkf commented on f7ce98a Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the unofficial nightly builds linked from the original issue (in the commit message).

@tansy

This comment was marked as resolved.

@tansy

This comment was marked as resolved.

@Vangelis66
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tansy : This is Google's latest gimmick to thwart audio-only downloads 😠 ... But, sadly, it isn't limited to these 😢 ...
The issue has been reported to "downstream" already, it's this one...

If you feel the need to, you can open an issue in this tracker, too, but NOT before you follow PINNED issue #30839...
BTW, commenting under commits is against the recommended "netiquette", unless you want to comment strictly on the committed code itself (and yes, by "helping" you I'm "committing" (pun intended 😃 ) the same netiquette violation 😜 ) ...

@dirkf
Copy link
Contributor Author

@dirkf dirkf commented on f7ce98a Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try extractor/youtube.py from dirkf@b076402. It doesn't seem to work with Py2.7, tho'. Also, do open an issue to continue.

@tansy
Copy link

@tansy tansy commented on f7ce98a Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been reported to "downstream" already, it's this one...

I've checked that but it's locked and there is no way to join the conversation. Some people say it's random. It's not. I haven't met any exception and slow down is not random either - the smaller the file (due to smaller bitrate) the slower the download. For example -f 249 (opus @ 46k) goes ~19 kB/s, -f 250 (opus @ 61k) goes 15 kB/s, and so on. Same applies to videos: -f 242 ( vp9@ 163k, 25fps, video only) ~40 kB/s, -f 243 (vp9@ 302k, 25fps, video only) ~75 kB/s and -f 18 (avc1.42001E, 25fps, mp4a.40.2; audio+video) ~2.1 MB/s. There is no randomness in it.

@tansy
Copy link

@tansy tansy commented on f7ce98a Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, commenting under commits is against the recommended "netiquette", unless you want to comment strictly on the committed code itself

That was the only issue/pull-request/commit/thread related to this topic I found. That's why I commented. Not because I fancy to break netiquette.

Please sign in to comment.