Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npo] Fix extractor #9319

Closed
wants to merge 3 commits into from
Closed

[npo] Fix extractor #9319

wants to merge 3 commits into from

Conversation

rvsit
Copy link
Contributor

@rvsit rvsit commented Feb 29, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

The NPO made quite some changes to NPO Start so the extractor was broken, this pr fixes that behavoir. Unfortunately a lot of newer video's are DRM protected so won't be helped by this although it now properly displays a drm error.

Tests now all work.

Fixes #8547 (Test URL provided has DRM)
Fixes #8453 (Test URL provided has DRM)

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added the site-bug Issue with a specific website label Mar 1, 2024
@bartbroere
Copy link
Contributor

Hi! Thanks for working on this. I've been working on NPO support on the youtube-dl side, especially the URLs that end with /afspelen. Feel free to check out how I do that over here:

ytdl-org/youtube-dl#31976

I'll be checking your branch to see how to support the URLs that don't work with my code yet.
I think together we support most use cases (aside from all the DRM that's added to new uploads).

@rvsit
Copy link
Contributor Author

rvsit commented Mar 1, 2024

Ahh thanks for bringing that one to my attention @bartbroere. I didn't realize that this was actually provided by the upstream youtube-dl. Just assumed it was part of the dlp additions. By all means please take what you can from my work. I think we should close this one and work on your PR (although I can't commit to it, so I'll try to follow it and let me know if I can help).

@rvsit rvsit closed this Mar 1, 2024
@bashonly bashonly added the closed-pr (Partially) valid PR that was closed by OP label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-pr (Partially) valid PR that was closed by OP site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPO / zapp.nl - Failed to parse JSON All videos on NPOstart.nl fail to analyze
4 participants