Fix EMSCRIPTEN build #198
Open
Fix EMSCRIPTEN build #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiem-sc
commented
Jan 26, 2022
| @@ -59,7 +59,9 @@ The Apache License, Version 2.0 (the "License"); | |||
| #else | |||
|
|
|||
| // Windows | |||
| # define WIN32_LEAN_AND_MEAN | |||
There was a problem hiding this comment.
removes
warning C4005: 'WIN32_LEAN_AND_MEAN': macro redefinition
mdiem-sc
commented
Jan 26, 2022
| @@ -77,6 +77,9 @@ inline profiler::thread_id_t getCurrentThreadId() | |||
| #elif defined(__QNX__) | |||
| EASY_THREAD_LOCAL static const profiler::thread_id_t _id = (profiler::thread_id_t)gettid(); | |||
| return _id; | |||
| #elif defined(__EMSCRIPTEN__) | |||
There was a problem hiding this comment.
fixes error when building with EMSCRIPTEN:
In file included from /easy_profiler_core/thread_storage.cpp:45:
/easy_profiler_core/current_thread.h:81:95: error: use of undeclared identifier '__NR_gettid'
EASY_THREAD_LOCAL static const profiler::thread_id_t _id = (profiler::thread_id_t)syscall(__NR_gettid);
mdiem-sc
commented
Jan 26, 2022
| @@ -91,7 +91,6 @@ namespace profiler { | |||
|
|
|||
| public: | |||
|
|
|||
| CSwitchEvent() = default; | |||
There was a problem hiding this comment.
removes
serialized_block.h:94:9: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
CSwitchEvent() = default;
^
serialized_block.h:88:39: note: default constructor of 'CSwitchEvent' is implicitly deleted because base class 'profiler::Event' has a deleted default constructor
class PROFILER_API CSwitchEvent : public Event
^
/details/profiler_public_types.h:117:9: note: 'Event' has been explicitly marked deleted here
Event() = delete;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easy_profiler_corebuild on emscripten.