Flamethrower Refactor 2024 #22035
Merged
Flamethrower Refactor 2024 #22035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
DME Edit
ToasterBiome
approved these changes
May 24, 2024
Yogbot-13
added a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Refactors flamethrowers to be a subtype of /obj/item/gun, because they're technically guns and should be treated as such. Behind the scenes the code is significantly improved, but the only notable player-facing change is it can fit in belt slots and armor suit storage now and the flames should travel much more smoothly.
Also fixes a few bugs like synths and pacifists being able to use flamethrowers, or deconstructing one resulting in a welding tool that's permanently unusable.
Why is this good for the game?
Vastly better code, fixes bugs, makes the fire travel in a more sane way.
Testing
flamethrower_test.mp4
Changelog
馃啈
tweak: Flamethrowers are now technically guns and can fit on your belt slot
bugfix: Fixed deconstructing flamethrowers causing the resulting welding tool to be permanently unusable
bugfix: Fixed flamethrowers being usable by pacifists and synths
/:cl: