Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking Rework #22029

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

SapphicOverload
Copy link
Contributor

@SapphicOverload SapphicOverload commented May 11, 2024

Document the changes in your pull request

This reworks blocking into a right-click action instead of random chance. Holding right click with combat mode enabled will block incoming attacks in the direction of your cursor with any held items that are capable of doing so, causing some stamina damage to yourself in the process (or oxygen damage if stun-immune). Holding block will also slow you down slightly and cannot be done while attacking.

Different items can block different things in different ways, for example most melee weapons cannot block ranged weapons but if the block is timed correctly, can parry to increase their blocking power. Shields generally have a higher blocking power but most cannot parry and take damage when blocking attacks.

There are also a few special cases, such as energy swords and other similar weapons deflecting laser-like projectiles when blocking them, dual energy swords and the bo staff being able to block in any direction, and the chaplain's holy weapons having a higher blocking power against attacks from cultists.

Additionally, certain exceptionally strong weapons like rockets, cannonballs, and supercharged vxtvul hammers cannot be blocked and will disarm you if you try.

Why is this good for the game?

This rework changes blocking to be a tactical decision rather than completely passive, making combat more fun in general. Blocking by random chance is boring and the way it stacks makes it extremely easy to abuse..

Testing

block_rework_test.mp4

Wiki Documentation

Later

Changelog

馃啈
experimental: Removes block chance, adds right-click blocking
/:cl:

@ThePissGuy
Copy link

does it make the tink sound from blood cult shields if parrying melee

@SapphicOverload
Copy link
Contributor Author

does it make the tink sound from blood cult shields if parrying melee

Yes

@MommaDragon
Copy link
Contributor

Make it clear if it's a parry or a block with sounds (and text), perhaps?

@wonderinghost
Copy link
Contributor

image

@SapphicOverload
Copy link
Contributor Author

Make it clear if it's a parry or a block with sounds (and text), perhaps?

Yeah it has a different sound when parrying as opposed to blocking

@PibeCantina
Copy link
Contributor

Does it have a cooldown?
Can i block and attack at the same time?

@SapphicOverload SapphicOverload requested a review from a team as a code owner May 11, 2024 18:16
@SapphicOverload
Copy link
Contributor Author

Does it have a cooldown? Can i block and attack at the same time?

You can't block and attack at the same time, and parrying does have a cooldown but blocking normally doesn't.

@github-actions github-actions bot added the Mapping Will result in a change to a map. label May 11, 2024
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map ist gut, godspeed with the rest

@LassiH
Copy link

LassiH commented May 12, 2024

isnt this a buff to every item that can block by giving them 100% block if you press right click

@SapphicOverload
Copy link
Contributor Author

isnt this a buff to every item that can block by giving them 100% block if you press right click

Yes and no. It lets you have a guaranteed block, but it causes you stamina damage and you can't attack at the same time.

@LassiH
Copy link

LassiH commented May 12, 2024

isnt this a buff to every item that can block by giving them 100% block if you press right click

Yes and no. It lets you have a guaranteed block, but it causes you stamina damage and you can't attack at the same time.

so if you got attacked by a tot you can just take out a ancient saber and ignore hits while calling for help
also does it prevent you from using secondary hand ?

@SapphicOverload
Copy link
Contributor Author

SapphicOverload commented May 12, 2024

so if you got attacked by a tot you can just take out a ancient saber and ignore hits while calling for help

You can only block in the direction you're facing, they can just walk behind you while you're typing. Not that you'd be typing very fast with one hand anyway.

Also yes it does just cancel the block if you try to do anything else.

@LassiH
Copy link

LassiH commented May 12, 2024

so if you got attacked by a tot you can just take out a ancient saber and ignore hits while calling for help

You can only block in the direction you're facing, they can just walk behind you while you're typing. Not that you'd be typing very fast with one hand anyway.

"block incoming attacks in the direction of your cursor " is it where your character is facing or where your cursor is facing ? and you can always walk into a corner to give yourself time

@SapphicOverload
Copy link
Contributor Author

"block incoming attacks in the direction of your cursor " is it where your character is facing or where your cursor is facing ? and you can always walk into a corner to give yourself time

It makes your character face your cursor. Also do keep in mind you can't block forever, if you try you'll eventually get knocked down and disarmed.

@LassiH
Copy link

LassiH commented May 12, 2024

how does it work for the mech weapons with block ?

@SapphicOverload
Copy link
Contributor Author

how does it work for the mech weapons with block ?

Mechs still use deflection chance, I haven't changed that system (yet)

@LassiH
Copy link

LassiH commented May 12, 2024

is the slowdown 0.5 ? it would make blocking near useless if you have to chase people
and does the makeshift desword have 360 block too ?

@SapphicOverload
Copy link
Contributor Author

is the slowdown 0.5 ? it would make blocking near useless if you have to chase people

Yes.

and does the makeshift desword have 360 block too ?

Also yes, and so does the bo staff.

@LassiH
Copy link

LassiH commented May 15, 2024

what about the adamantite shield from xenobiology its only purpose is to block and already gives a slowdown for just holding it or the energy shields and do deswords reflect laser projectiles when not blocking

@SapphicOverload SapphicOverload added Balance Council Approved This PR was approved by the Balance Council. and removed Awaiting - Action - Balance Review Code Director Review labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Council Approved This PR was approved by the Balance Council. Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants