Refactors lava into being a component with different types for toxic water and plasma rivers #22017
+287
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
Fix
SapphicOverload
approved these changes
May 11, 2024
Moltijoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was initially just copying code from lava over to toxic water
but i decided it would be better if refactored into a component
so now it is
Why is this good for the game?
code quality + consistency between similar features
also, it makes it easier to create new types of terrain that do stuff to people standing on it
(could make healing terrain that heals instead of doing damage)
Testing
🆑
tweak: Refactors lava into being a component with different types for toxic water and plasma rivers
bugfix: can now rcd toxic water
bugfix: boats and grilles now protect from toxic water
experimental: please tell me DIRECTLY if there's anything wonky about lava/plasma/toxic water
/:cl: