Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT TG] ports some disposal changes, reroutes box and more disposals #21983

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

wonderinghost
Copy link
Contributor

@wonderinghost wonderinghost commented Apr 30, 2024

Document the changes in your pull request

Portholders: @Comxy (disposal rotators), @ArcaneMusic (disposal bins can hold destination taggers), @TheBonded (disposal junction sprites), and @Profakos (disposal fix and mapping sort helpers)

ports disposal routers:
Transit Tube Fix and New Rotator Disposal Pipe #77843
destination tagger holder:
Disposal bins can now hold a destination tagger, and adds a few throughout maps. #81991
junction resprites:
New disposals junction sprites #66217
wrap disposal fix:
Package delivery sorter fix, autodocs #72865
mapping helpers:
Mail sorting helper, and disposals fixes #70861

resprites for disposal junctions since they are more easily readable
adds a rotator disposal pipe, items that enter will be rotated 90 degrees
disposal bins can now hold destination taggers, right click to put on and take off a destination tagger from a bin
adds a new mapping helper, mail sorting is quicker to configure by dropping a helper over a mail sort junction
wrap pipes now pull wrapped packages from disposal system

Why is this good for the game?

gives disposals some needed love. for mappers the rotator might be useful for more neat disposal lines.
with the new helper it will automatically configure mail sorting pipes on lateload. instead of configuring a pipe in a bunch of variables you can just drop the mail sorting helper over the pipe to configure
holders on the bins means it can be easier to deliver stuff in between departments. dotted in head offices (qm included), cargo, viro and warden's bin
if you ever saw our current disposal junction sprites you'll understand why
wrap pipes always existed but was broken, now wrapped packages will be pulled out of the disposal loop if isnt delivered or unmarked

#Wiki
update guide to mapping disposal section with mentioning of new disposal pipes and helpers

Testing

edited box to reorganize and test pipes, more to be routed once i get other stuff done

Spriting

image
image

To Do

  • map compilers hates this rotator pipe, dont look at me ive got no idea how to fix it

Changelog

🆑
rscadd: adds a destination tagger holder to bins and a disposal rotator
rscadd: adds a sort mail helper, drop on sort pipe to configure
mapping: reroutes box disposal pipes for the moment
bugfix: wrap pipes now pull wrapped packages out to the side
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Sprites This PR has spriting changes Tweak This PR contains changes to the game. labels Apr 30, 2024
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Apr 30, 2024
@wonderinghost wonderinghost marked this pull request as ready for review May 10, 2024 05:04
@wonderinghost wonderinghost requested a review from a team as a code owner May 10, 2024 05:04
@wonderinghost
Copy link
Contributor Author

atomizing a project

@wonderinghost wonderinghost reopened this May 11, 2024
@wonderinghost wonderinghost requested a review from a team as a code owner May 11, 2024 02:45
@AMyriad
Copy link
Contributor

AMyriad commented May 13, 2024

Could you please link what you're porting, give credit to the authors in the changelog, or explain at all what any of this does?

@wonderinghost
Copy link
Contributor Author

Could you please link what you're porting, give credit to the authors in the changelog, or explain at all what any of this does?

technically my first port, so i dont have a exact idea how to do things, give me a moment

@Cyberboss
Copy link
Contributor

The OG authors are @Comxy and @ArcaneMusic. Not me and the other guy

@wonderinghost
Copy link
Contributor Author

noticed one more disposal change that can be helpful for mappers, drafting to work on

@wonderinghost wonderinghost marked this pull request as draft May 13, 2024 20:58
@wonderinghost
Copy link
Contributor Author

The OG authors are @Comxy and @ArcaneMusic. Not me and the other guy

shit sorry, didnt notice that

@wonderinghost wonderinghost marked this pull request as ready for review May 14, 2024 04:31
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just taking a cursory glance here, but this is a semi-significant change to box maint.
Since it's not crucial to what you're tryin to do here, I suggest you do this in a separate PR if you really want to take this area out of space, so please revert it for the time being.
image

@AMyriad
Copy link
Contributor

AMyriad commented May 14, 2024

Also why add this section, if I may ask?
image

@wonderinghost
Copy link
Contributor Author

Rerouting disposal lines. If there wasn't more then something may have fucked up on my end because I relooped the disposal line to not run like before

@wonderinghost
Copy link
Contributor Author

Also why add this section, if I may ask?

image

@Profakos
Copy link
Contributor

I am always happy when people use the disposal sorting helpers.

@wonderinghost
Copy link
Contributor Author

couldnt update my branch for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Mapping Will result in a change to a map. Sprites This PR has spriting changes Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants