Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 001 002 003（feature-001_002_003） #5

Merged
merged 21 commits into from Mar 19, 2024
Merged

fix 001 002 003（feature-001_002_003） #5

merged 21 commits into from Mar 19, 2024

Conversation

yko-git
Copy link
Owner

@yko-git yko-git commented Mar 15, 2024

FBをいただいたところを一度pushしています。
お手隙でご確認お願いできますでしょうか。

以下2点が解決できず途中段階です
e91bd4c3fd5f8b968cd970eff00106d657d8fdbc

version1-workspace@0c6e93d

@yko-git
fix 001_syntax/006_object
a45dca8
@yko-git
fix 002_class/003_data filter
034b4f9
@yko-git
fix 001_easy length(lengthプロパティを使用しないパターン)
87284e0
@yko-git
fix 001_easy reverse(forを使用して処理を短く、でもjoinは使ってしまっている)
4e0d134
@yko-git
fix 001_easy findIndex (forを使用してシンプルに)
73759ce
@yko-git
fix 001_easy average (return後の不要なelseのカッコを削除)
72e8d0a
@yko-git
fix 001_easy concat (for文で実装し直し)
e52ef3a
@yko-git
fix 001_easy size (for文を使用して実装し直し)
091cc24
@yko-git
fix 001_easy omitSeq (最後にfilterを使用せずに実装し直し)
d727e15
@yko-git
fix 002_medium removeVowels (複数の比較だと値が取れない)
e91bd4c
@yko-git
fix 002_medium isPalindrome (不要なifを削除)
8ef3905
@yko-git
fix 002_medium isPalindrome (for文で実装し直し)
9477079
@yko-git
fix 002_medium isPrime (別のやり方で実装中ですが途中段階)
0c6e93d
@yko-git yko-git self-assigned this Mar 15, 2024
version-1
version-1 reviewed Mar 15, 2024
View reviewed changes
003_practice/001_easy.js Outdated Show resolved Hide resolved
version-1
version-1 reviewed Mar 15, 2024
View reviewed changes
003_practice/001_easy.js Outdated Show resolved Hide resolved
version-1
version-1 reviewed Mar 15, 2024
View reviewed changes
003_practice/001_easy.js Outdated Show resolved Hide resolved
version-1
version-1 reviewed Mar 15, 2024
View reviewed changes
003_practice/001_easy.js Outdated Show resolved Hide resolved
@yko-git
Copy link
Owner Author

yko-git commented Mar 18, 2024

@version-1 FBいただいたところを修正いたしました。
お手隙でご確認よろしくお願いいたします。

@yko-git yko-git merged commit decb049 into develop Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@version-1 version-1 version-1 left review comments

Assignees

@yko-git yko-git

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yko-git @version-1