1586 Continue migration of tests to JUnit 5 for org.cactoos.func package #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kachurinaa thank you for your contribution. If you are still up to it, could you fix the conflict and also update the todo so that this one is closed and a new one is created? It's enough to just change the reference of the ticket of the todo in the pom.xml file from |
added 11 commits
July 19, 2022 17:08
aakachurin
force-pushed
the
1586-kachurinaa
branch
from
05f9202
to
13ea3ee
Compare
|
@victornoel could you please approve it if it's ok? |
|
@kachurinaa very nice, thank you! It looks good, I will merge it after the CI has passed |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1586: