New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to axum 0.7 #17
Open
sunsided
wants to merge
23
commits into
main
Choose a base branch
from
feature/update-axum
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graceful shutdown will be potentially unblocked by: |
sunsided
force-pushed
the
feature/update-axum
branch
from
December 6, 2023 21:26
0368099
to
d8a0be4
Compare
This implementation is not graceful; when a yeet is in flight and the server is seeing a shutdown, the connection is canceled right away.
sunsided
force-pushed
the
feature/update-axum
branch
from
December 6, 2023 21:27
d8a0be4
to
2766a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to axum 0.7 / hyper 1.0. This is currently blocked due to axum not exposing a graceful shutdown functionality, as it internally uses hyper-utils' auto builder which doesn't expose it.