WIP: Rename smooth_terms to additional_terms #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add some tests? |
richford
changed the title
richford
force-pushed
the
enh/additional-terms
branch
from
55f791b
to
b52e57f
Compare
arokem
reviewed
Jul 21, 2023
| @@ -99,48 +94,17 @@ build_formula <- function(target, covariates, smooth_terms = NULL, group_by = "g | |||
| #' k = "auto") | |||
| #' } | |||
| fit_gam <- function(df_tract, | |||
| target = NULL, | |||
There was a problem hiding this comment.
I think that we do want to allow target to be NULL for the case that the user provides a formula.
This is the test that is currently failing on the CI.
| method="fREML", | ||
| ...) { | ||
|
|
||
| # Check that if formula is non-NULL, all the other formula-setting inputs |
There was a problem hiding this comment.
Why is this code being removed? This code is here to deal with the two options: provide a formula, or let the code build the formula from the inputs. Unless I am missing something, I don't think that the current PR should be eliminating these options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52