Test All Open Administrations on Release #517
Conversation
|
Visit the preview URL for this PR (updated for commit d7f90df): https://roar-staging--pr517-test-open-administra-6b4bc6jt.web.app (expires Mon, 20 May 2024 18:24:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
3 flaky tests on run #1617 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Play Optional Games > Plays ROAR - Word |
Test Replay
Screenshots
|
|
playFluency-ARF.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Test playthrough of Fluency as a participant > Fluency Playthrough Test |
Test Replay
Screenshots
|
|
es-tests/playFluency-ARF-ES.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Test playthrough of Fluency ARF ES as a participant > Fluency Playthrough Test |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #517 ↗︎
cypress/support/commands.js
Outdated
| @@ -105,6 +105,7 @@ Cypress.Commands.add('selectAdministration', (testAdministration) => { | |||
| .contains(testAdministration) | |||
| .should('exist') | |||
| .click(); | |||
| cy.log('Selectected administration:', testAdministration); | |||
There was a problem hiding this comment.
Should this be corrected to Selected?
| containers: [1, 2, 3, 4] | ||
| env: | ||
| NODE_ENV: 'test' | ||
| CYPRESS_BASE_URL: 'http://localhost:5173' |
There was a problem hiding this comment.
Should this use the staging link instead of localhost?
There was a problem hiding this comment.
I don't think so, because we are testing the open administrations that have been synced from production Firestore to development Firestore. Running on dev will also allow us to run super admin tests which can clean up the dev database on a new relese (i.e. deleting all test runs).
cypress/support/helper-functions/roar-multichoice/languageOptions.js
Outdated
Show resolved
Hide resolved
| async function getOpenAdmins() { | ||
| cy.get('[data-cy=dropdown-select-administration]').click(); | ||
| cy.get('.p-dropdown-panel').within(() => { | ||
| cy.get('li').each((el) => { | ||
| if (el.text().includes('Synced Administration')) { | ||
| openAdmins.push(el.text()); | ||
| } | ||
| }); | ||
| }); | ||
| cy.get('[data-cy=dropdown-select-administration]').click(); | ||
| } | ||
|
|
||
| const openAdmins = []; |
There was a problem hiding this comment.
I suggest returning the openAdmins array from this function. Also, does this function need to be async? If so, I think we need to await it below. If not, can we remove the async from it?
| async function getOpenAdmins() { | |
| cy.get('[data-cy=dropdown-select-administration]').click(); | |
| cy.get('.p-dropdown-panel').within(() => { | |
| cy.get('li').each((el) => { | |
| if (el.text().includes('Synced Administration')) { | |
| openAdmins.push(el.text()); | |
| } | |
| }); | |
| }); | |
| cy.get('[data-cy=dropdown-select-administration]').click(); | |
| } | |
| const openAdmins = []; | |
| async function getOpenAdmins() { | |
| const openAdmins = []; | |
| cy.get('[data-cy=dropdown-select-administration]').click(); | |
| cy.get('.p-dropdown-panel').within(() => { | |
| cy.get('li').each((el) => { | |
| if (el.text().includes('Synced Administration')) { | |
| openAdmins.push(el.text()); | |
| } | |
| }); | |
| }); | |
| cy.get('[data-cy=dropdown-select-administration]').click(); | |
| return openAdmins | |
| } |
There was a problem hiding this comment.
Thanks for the suggestion. No, this function does not need to be async afterall.
ksmontville
force-pushed
the
test-open-administrations
branch
2 times, most recently
from
4fa4d44
to
47d36fa
Compare
ksmontville
force-pushed
the
test-open-administrations
branch
from
06a31be
to
d7f90df
Compare
|
Closing this PR since its testing related changes have been incorporated into this PR: #570 |
This PR sets up a Cypress testing environment to test all currently open administrations on the ROAR dashboard. After administrations have been synced from production, the dev environment spins up and will loop through each assigned administration, then loop through and play each game assigned to that admininstration. If all games complete and all tests pass, the release will proceed.