Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Parallelize tracking #652

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Mar 23, 2021

Along the way, this also fixes a couple of bugs in mask handling in csd/dti, and allows passing an already-initialized direction getter object into the tracking, in case that's a thing you want to do (I use it to inject a bootstrap direction getter into the tracking, without giving it the raw data).

@pep8speaks
Copy link

pep8speaks commented Mar 23, 2021

Hello @arokem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:1: E402 module level import not at top of file

Comment last updated at 2021-04-19 18:21:46 UTC

@arokem
Copy link
Collaborator Author

arokem commented Mar 23, 2021

One challenge with the parallelization done this way is that I can't seem to be able to use other backends than "threading" because the direction getter and tracker objects that get sent into the parallelized function cannot be pickled by python. I still need to do some more experiments with this to see whether this even provides any performance gains.

@arokem arokem changed the title Parallelize tracking WIP: Parallelize tracking Mar 23, 2021
@arokem
Copy link
Collaborator Author

arokem commented Apr 7, 2021

I should try out pathos, which uses dill to serialize Python objects. Might get past the issues I am seeing here now.

@arokem
Copy link
Collaborator Author

arokem commented Apr 19, 2021

I am trying to make the Cython objects in DIPY pickle-able, based on https://ask.sagemath.org/question/8376/pickling-extension-classes/, but still doesn't work yet.

@arokem arokem added this to the pyAFQ 2.0 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants