[ENH, WIP] More tracking options #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Apr 17, 2024
| @@ -72,8 +72,8 @@ def _arglist_to_string(args, get_attr=None): | |||
| def name_from_path(path): | |||
| file_name = op.basename(path) # get file name | |||
| file_name = drop_extension(file_name) # remove extension | |||
| if "-" in file_name: | |||
| file_name = file_name.split("-")[-1] # get suffix if exists | |||
| if "_" in file_name: | |||
There was a problem hiding this comment.
Are we even using this function?
There was a problem hiding this comment.
ParticipantAFQ uses this function to generate names for scalars that the user inputs (such as a t1 image from another pipeline). I should make it so the user can also define a name, and we call this function only if a name is not provided.
|
We are going to try it for the baby data Howard is working with. We can remove it if it turns out not to be useful |
|
It turns out ptt is also pretty slow, but thats only like two lines, so I think we can keep that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.