DOC: Adds a tract profile plot to the ALS example. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fixes a small bug in the plot_tract_profile function, which assumes that the inputs are arrays, by referring to the `group_by.shape` attribute. This is one option for addressing this. Another would be to require this input to be an array. I also changed the example to download the data and load it as two separate steps, because I don't think that the automagical version is as useful for someone getting started with the software.
|
The only failer here is reduction in coverage, which seems benign. At some point, we might want to add smoke testing for the plotting code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fixes a small bug in the plot_tract_profile function, which assumes that the inputs are arrays, by referring to the
group_by.shapeattribute.This is one option for addressing this. Another would be to require this input to be an array.
I also changed the example to download the data and load it as two separate steps, because I don't think that the automagical version is as useful for someone getting started with the software.